Skip to content

aarch64 build fixes for 2.19.1 (WIP) #465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
dslarm wants to merge 7 commits into
base: main
Choose a base branch
from
Open

aarch64 build fixes for 2.19.1 (WIP) #465

dslarm wants to merge 7 commits into from

Conversation

@dslarm
Copy link
Contributor

@dslarm dslarm commented Nov 11, 2025

This PR will get us going again on linux-aarch64

  • remove previous python package id limits
  • fix build issue in xla

Work in progress:

  • Locally this reaches the end of the compilation phase (no C++ compile errors :0), but there's a wheels problem:

  • a) it looks to me like it's trying to make x86_64 ones when doing aarch64 - although that does not error (surely it should.) - smells like it's from the bazel part of the build:

[17,433 / 17,437] Writing: bazel-out/aarch64-opt/bin/tensorflow/tools/lib_package/libtensorflow.tar.gz; 35s local ... (3 actions running)
[17,436 / 17,437] Action tensorflow/tools/pip_package/wheel_house/tensorflow-2.19.1-cp39-cp39-linux_x86_64.whl; 1s local
[17,436 / 17,437] Action tensorflow/tools/pip_package/wheel_house/tensorflow-2.19.1-cp39-cp39-linux_x86_64.whl; 10s local
[17,436 / 17,437] Action tensorflow/tools/pip_package/wheel_house/tensorflow-2.19.1-cp39-cp39-linux_x86_64.whl; 40s local
INFO: Elapsed time: 2038.825s, Critical Path: 275.04s
INFO: 17229 processes: 686 internal, 16543 local.

and

  • b) it particularly doesn't like python 3.12:
Setting up cross-python
Finished setting up cross-python
++ /home/conda/feedstock_root/build_artifacts/tensorflow-split_1762861445005/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_plac/bin/python -c 'import sys;print('\''.'\''.join(str(v) for v in sys.version_info[:2]))'
+ PY_VER=3.12
+ /home/conda/feedstock_root/build_artifacts/tensorflow-split_1762861445005/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_plac/bin/python -m pip install --no-deps /home/conda/feedstock_root/build_artifacts/tensorflow-split_1762861445005/work/tensorflow_pkg/tensorflow-2.19.1-cp312-cp312-linux_x86_64.whl
ERROR: tensorflow-2.19.1-cp312-cp312-linux_x86_64.whl is not a supported wheel on this platform.

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@dslarm dslarm changed the title aarch64 build fixes for 2.19.1 aarch64 build fixes for 2.19.1 (WIP) Nov 11, 2025
@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Nov 11, 2025 •
edited
Loading

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • ℹ️ The recipe is not parsable by parser conda-souschef (grayskull). This parser is not currently used by conda-forge, but may be in the future. We are collecting information to see which recipes are compatible with grayskull.
  • ℹ️ The recipe is not parsable by parser conda-recipe-manager. The recipe can only be automatically migrated to the new v1 format if it is parseable by conda-recipe-manager.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/21003886856. Examine the logs at this URL for more detail.

@dslarm dslarm mentioned this pull request Nov 11, 2025
Draft
@dslarm
Copy link
Contributor Author

dslarm commented Nov 11, 2025 •
edited
Loading

also need to check this line from the build output:

WARNING (libtensorflow_cc): run-exports library package conda-forge/linux-aarch64::libstdcxx-ng==15.2.0=hf1166c9_7 in requirements/run but it is not used (i.e. it is overdepending or perhaps statically linked? If that is what you want then add it to `build/ignore_run_exports`)
  • aarch64 builds are restricted to using gcc11 at the moment - so wasn't expecting to see 15.x.x

@h-vetinari
Copy link
Member

h-vetinari commented Nov 29, 2025

also need to check this line from the build output:

This is fine. We always use the newest C++ standard library implementation, even if you compile with older compiler versions. That works because the standard libraries (libcxx and libstdcxx) are highly backwards compatible

h-vetinari
h-vetinari reviewed Nov 29, 2025
View reviewed changes
dslarm and others added 2 commits November 29, 2025 16:21
@dslarm @h-vetinari
enabling aarch64 compilation for 2.19.1
8ad90ca 
- remove previous python package id limits
- fix build issue in xla

Co-Authored-By: H. Vetinari <[email protected]>
@h-vetinari
DEBUG: only aarch
dd5aec0
@h-vetinari h-vetinari mentioned this pull request Nov 29, 2025
Closed
@h-vetinari
Copy link
Member

h-vetinari commented Nov 29, 2025

Same error as you noted in the OP already

+ PY_VER=3.12
+ $PREFIX/bin/python -m pip install --no-deps $SRC_DIR/tensorflow_pkg/tensorflow-2.19.1-cp312-cp312-linux_x86_64.whl
ERROR: tensorflow-2.19.1-cp312-cp312-linux_x86_64.whl is not a supported wheel on this platform.

This will probably require patching the bazel files

@hmaarrfk hmaarrfk marked this pull request as draft December 1, 2025 03:24
@dslarm
Copy link
Contributor Author

dslarm commented Jan 13, 2026 •
edited
Loading

Spent some time trying to get to bottom of bazel system and interaction with building the wheels. I could not see how the platforms// etc gets populated or an equivalent 'target' platform - but a simple (dirty) change of telling the python script that the target is arm64 resolved it.

Do any of the maintainers here know a better attribute/variable that would be the actual build target - my patch is simple but the build now completes successfully:

-    platform_tag = select({
-        "@platforms//cpu:aarch64": "arm64",
-        "@platforms//cpu:arm64": "arm64",
-        "@platforms//cpu:x86_64": "x86_64",
-        "@platforms//cpu:ppc": "ppc64le",
-    }),
+    platform_tag = "arm64",

(obviously this patch is conditional on being a linux-aarch64 build..)

@dslarm
Copy link
Contributor Author

dslarm commented Jan 14, 2026

Spent some time trying to get to bottom of bazel system and interaction with building the wheels. I could not see how the platforms// etc gets populated or an equivalent 'target' platform - but a simple (dirty) change of telling the python script that the target is arm64 resolved it.

The docs suggest that '@platforms//cpu' is supposed to be the result of bazel --cpu .. - in our case, the target cpu (aarch64), so why that's not the case in practice, I don't know.

@dslarm dslarm marked this pull request as ready for review January 14, 2026 17:25
@dslarm
Copy link
Contributor Author

dslarm commented Jan 14, 2026

@conda-forge-admin, please rerender

@dslarm
Copy link
Contributor Author

dslarm commented Jan 14, 2026

@conda-forge-admin, please rerender

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@h-vetinari h-vetinari h-vetinari left review comments

@FarhanTejani FarhanTejani Awaiting requested review from FarhanTejani FarhanTejani is a code owner

@ghego ghego Awaiting requested review from ghego ghego is a code owner

@hajapy hajapy Awaiting requested review from hajapy hajapy is a code owner

@hmaarrfk hmaarrfk Awaiting requested review from hmaarrfk hmaarrfk is a code owner

@isuruf isuruf Awaiting requested review from isuruf isuruf is a code owner

@jschueller jschueller Awaiting requested review from jschueller jschueller is a code owner

@ngam ngam Awaiting requested review from ngam ngam is a code owner

@njzjz njzjz Awaiting requested review from njzjz njzjz is a code owner

@waitingkuo waitingkuo Awaiting requested review from waitingkuo waitingkuo is a code owner

@wolfv wolfv Awaiting requested review from wolfv wolfv is a code owner

@xhochy xhochy Awaiting requested review from xhochy xhochy is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dslarm @conda-forge-admin @h-vetinari